Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker: Ocular Gatsby website #756

Closed
35 of 59 tasks
1chandu opened this issue Oct 12, 2018 · 2 comments
Closed
35 of 59 tasks

Tracker: Ocular Gatsby website #756

1chandu opened this issue Oct 12, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@1chandu
Copy link
Contributor

1chandu commented Oct 12, 2018

Currently planned as rolling update after 7.0 release

Example Improvements

  • GLTF:
    • no loading spinner
    • doesn't load cameras, no autosizing
  • Add glfx example
  • Texture3D: Add rotation controls?

7.4 Website Fixes

Styling Issues

  • (Safari-only) Uber Move font on titles incorrectly falling back to Times New Roman?
  • Minor styling issues on What's New page, missing section breaks
  • Long text getting cutoff in docs table of contents - https://tgorkin.github.io/docs/api-reference/webgl/context/get-parameters
  • Layout issues on mobile on main page and examples
  • Edge - Example canvas keep increasing in size (maybe related to recent devicePixelRatio work?)
  • Edge - Front page header bar lags behind scroll
  • Edge - Font page header test offscreen. Only "Examples" and "Documentation" visible.

Link issues

  • 404 error on /page-data/docs/developer-guide/get-started/page-data.json

Misc Issues

  • "Missing content for entry X" console warnings on Examples page
  • Missing message on WebGL2-only examples, likely a layout issue (Safari)
  • No category headers for examples (Core/Lessons etc).
  • Example titles in TOC are different than non-gatsby site, for instance several WebGL2 only examples are marked as such in the TOC

Suggested Improvements

  • Not a bug, but lessons have names (like Adding Color...), we could add to Examples TOC, to make it more interesting.

7.3 Ocular Gatsby Tasks

  • Website (docs and example) testing: staging
    • Testing on Chrome
    • Testing on Safari
    • Testing on Firefox
    • Testing on Edge
    • Testing on IE11 (major issues expected)
    • Testing on iOS
    • Testing on Android

P0 Issues

Styling Issues

Link Issues

Deferred

  • Console error after browsing many examples "There are too many active WebGL contexts on this page, the oldest context will be lost."

7.0 Ocular Gatsby Website Testing

WEBSITE EXAMPLES

  • can't scroll to all examples in example TOC.
  • overview page, missing thumbnails for DoF, Texture3D, GLTF, ...
  • StatsWidget Obscures UI, move to lower right corner?
  • TransformFeedback: Broken
  • GLTF:
    • loaders.gl dependency
  • Lesson 10, (ugly, no mouse control...)
  • Lesson 13, no textures
  • Lesson 15, tilt earth towards northern hemisphere

7.0 Ocular Gatsby Website Transition

WEBSITE DEV TASKS:

  • Fix styling for markdown and home page
  • Fix home page
  • Add example thumbnails
  • Make examples resize to available space
  • Example TOC not scrollable after a while? (Maybe not reproducible?)
  • Gatsby remove console.log(StaticQuery) (Maybe use probe.gl to hide?)
  • Remove console warnings around links

EXAMPLE DEV TASKS

  • WebGL context reuse in examples
  • Add gltf example

TESTS:

Also see ocular-gatsby progress in uber-web/ocular#74

6.x Ocular (Classic) Website Transition (Didn't make it into 6.2)

Ocular website is branched off of master during 6.2 release due to following issues , we need to resolve these before enabling it:

https://github.com/uber/luma.gl/tree/ocular-Oct2018

Ocular-specific Testing/Bugs:

  • Check pages in website, that layout is readable, skip through all pages
  • Auto zoom is only affecting Safari/Edge (may be IE too?) but runs fine on Chrome.
  • luma.gl title overlaps with sub title in front page
  • Examples
    • Automatic zoom in for Safari and Firefox
    • window resize: Object zooms in but not zooms out once the window size changes
  • Fix InfoPanel for examples in new ocular website (@jckr Move luma.gl website to ocular #583)
  • Transform demo is not linked in website.
@1chandu 1chandu added this to the Backlog milestone Oct 12, 2018
@1chandu 1chandu mentioned this issue Oct 29, 2018
38 tasks
@ibgreen ibgreen changed the title Ocular website issues Tracker: Ocular website issues Dec 19, 2018
@ibgreen ibgreen changed the title Tracker: Ocular website issues Tracker: Ocular Gatsby website Jan 10, 2019
@ibgreen ibgreen added the P1 label Jan 10, 2019
@ibgreen ibgreen modified the milestones: Backlog, V 7.0.0 Jan 10, 2019
This was referenced Mar 19, 2019
ibgreen added a commit that referenced this issue Mar 19, 2019
<!-- For feature, feature enhancement or bug fix, create an issue first and finish To Do List there -->
<!-- Anything doesn't work as expected is a bug, including code, doc and test -->
# For #756
<!-- For other PRs without open issue -->
#### Background
<!-- For all the PRs -->
#### Change List
-
@tsherif tsherif mentioned this issue Apr 2, 2019
@ibgreen ibgreen modified the milestones: V 7.0.0, V 7.1.0 Apr 15, 2019
@tgorkin tgorkin modified the milestones: V 7.1.0, v7.2.0 Jun 4, 2019
@tgorkin tgorkin modified the milestones: 7.2, 7.3 Aug 9, 2019
@tsherif
Copy link
Contributor

tsherif commented Sep 17, 2019

Possible clue about the layout issue in the docs. When I navigate to docs from the front page, the side bar and text don't share an ancestor except for what appears to be the top level, and the text appears full size. When I navigate directly to the doc page, they're direct siblings inside an element that looks like it has the correct width for the text.

The hint I got (thanks to Edge's slower rendering) was that on direct navigation, I see the text show up at correct width for a moment before the sidebar is displayed, which then "squishes" the text when it's inserted.

Is the some logic in ocular-gatsby to decide where to insert the sidebar that might be going haywire?

@ibgreen
Copy link
Collaborator

ibgreen commented Sep 17, 2019

Is the some logic in ocular-gatsby to decide where to insert the sidebar that might be going haywire?

We are doing gatsby "page wrapping" to make sure the shared components don't get reloaded, but this setup already seemed broken based on the jumping TOC, this seems like more evidence that this is the issue.

https://www.gatsbyjs.org/docs/browser-apis/#wrapPageElement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants