Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Move out deepEqual, getShaderInfo #2005

Merged
merged 2 commits into from
Mar 6, 2024
Merged

chore(core): Move out deepEqual, getShaderInfo #2005

merged 2 commits into from
Mar 6, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 6, 2024 •
edited
Loading

For #2000

Background

  • Move out utils or remove utils in core

Change List

  • Move deepEqual to engine (Model is only user)
  • Minimal refactor of getShaderInfo and move into shader.ts
  • Remove loadFile
  • Move loadScript into modules/webgl
  • ...

dist/index.cjs 71.2kb (down from 76.9kb)

@ibgreen ibgreen marked this pull request as ready for review March 6, 2024 21:48
@ibgreen ibgreen merged commit cedc3a1 into master Mar 6, 2024
1 check passed
@ibgreen ibgreen deleted the ib/shader-info branch March 6, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ibgreen