Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgl: Check for WEBGLTextureView, not WEBGLTexture #2014

Merged
merged 1 commit into from
Mar 8, 2024
Merged

webgl: Check for WEBGLTextureView, not WEBGLTexture #2014

merged 1 commit into from
Mar 8, 2024

Conversation

felixpalmer
Copy link
Collaborator

Background

Causing a number of 'No texture' crashes in deck, because value.colorAttachments[0] instanceof WEBGLTexture should never be true

Change List

  • Check for WEBGLTextureView, not WEBGLTexture

@felixpalmer felixpalmer requested a review from ibgreen March 8, 2024 11:20
@felixpalmer felixpalmer merged commit 8c166b6 into master Mar 8, 2024
1 check passed
@felixpalmer felixpalmer deleted the felix/textureview-check branch March 8, 2024 11:23
felixpalmer added a commit that referenced this pull request Mar 8, 2024
@felixpalmer
webgl: Check for WEBGLTextureView, not WEBGLTexture (#2014)
41159cc
@ibgreen ibgreen mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@felixpalmer