Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgl: Check for WEBGLTextureView, not WEBGLTexture #2014

Merged
merged 1 commit into from
Mar 8, 2024
Merged

webgl: Check for WEBGLTextureView, not WEBGLTexture #2014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/webgl/src/adapter/resources/webgl-render-pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,12 +463,12 @@ export class WEBGLRenderPipeline extends RenderPipeline {
texture = value;
} else if (
value instanceof WEBGLFramebuffer &&
value.colorAttachments[0] instanceof WEBGLTexture
value.colorAttachments[0] instanceof WEBGLTextureView
) {
log.warn(
'Passing framebuffer in texture binding may be deprecated. Use fbo.colorAttachments[0] instead'
)();
texture = value.colorAttachments[0];
texture = value.colorAttachments[0].texture;
} else {
throw new Error('No texture');
}
Expand Down