Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(webgl): Avoid WEBGL_polygon_mode extension warning #2029

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore(webgl): Avoid WEBGL_polygon_mode extension warning #2029

merged 1 commit into from
Mar 13, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 13, 2024 •
edited

For #

Background

  • Start addressing console warnings.

Change List

  • One warning comes from luma.gl initializing extensions at initialization, before we use them (which we temporarily reverted to since the v9 on-demand approach caused some deck.gl regression).
  • This PR avoids initializing the extension in question.

@ibgreen ibgreen marked this pull request as ready for review March 13, 2024 16:31
@ibgreen ibgreen merged commit 54af690 into master Mar 13, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/remove-warning-extensions branch March 13, 2024 20:54
ibgreen added a commit that referenced this pull request Mar 13, 2024
@ibgreen
chore(webgl): Avoid WEBGL_polygon_mode extension warning (#2029)
a11dda8
@Pessimistress Pessimistress mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ibgreen