fix: Support sharing cached Pipelines with different parameters/topology in WebGL #2034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion.
Background
Change List
parameters
andtopology
.RenderPipeline.parameters/topology
if provided.Notes
Commentary
There is a balance between completely pushing this type of logic down into
core
and keepingcore
as a thin GPU API mapping layer.I have given this quite a bit of thought. By handling some small amounts of device differences like this in the
Model
, we can keep the complexity of the@luma.gl/core
module low and we still hide WebGL/WebGPU differences from applications.There are a few other differences such as constant attributes and TransformFeedback that that are also handled this way. I feel that this is a good balance, better than the alternatives.