Import mapbox-gl such that it is transpilable #1365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
react-map-gl does not ship its own pre-bundled version. All files are simply transpiled by babel. Correct me if I'm wrong, but this change means that every user will have to add a worker-loader config to their bundler to be able to use this library. An alternative would be to distribute a pre-built mapbox-gl bundle with react-map-gl - I believe that is going to introduce some licensing issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from the transpilation issues described in mapbox/mapbox-gl-js#10173
With this PR I'm attempting to switch the import for mapbox-gl-js, and use the
mapboxgl.workerClasshook so that the build system can recognize the separate bundles for main-thread and worker code.This should allow arbitrary transpilation with Babel because it makes it aware of the multi-entrypoint nature of the library.