Skip to content

Commit

Permalink
Fixed location is undefined error
Browse files Browse the repository at this point in the history
  • Loading branch information
vishalmshah committed Feb 19, 2018
1 parent 40aa223 commit 73fb3fe
Show file tree
Hide file tree
Showing 7 changed files with 351 additions and 28 deletions.
1 change: 1 addition & 0 deletions boilerplate-react/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

# misc
.DS_Store
.env
.env.local
.env.development.local
.env.test.local
Expand Down
4 changes: 3 additions & 1 deletion boilerplate-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@
"react-dom": "^16.2.0",
"react-flexbox-grid": "^2.0.0",
"react-router-dom": "^4.2.2",
"react-scripts": "^1.1.1",
"validator": "^9.4.1"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --env=jsdom",
"eject": "react-scripts eject"
"eject": "react-scripts eject",
"lint": "eslint src"
},
"devDependencies": {
"eslint": "^4.18.0",
Expand Down
5 changes: 3 additions & 2 deletions boilerplate-react/src/App.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
/* eslint-disable */

import React from 'react';
import { Route, Switch } from 'react-router-dom';
import { Route } from 'react-router-dom';
import { HomePage, LoginPage } from "./components/pages";
// import { Grid } from 'react-flexbox-grid';
import 'react-flexbox-grid/dist/react-flexbox-grid.css';

// TODO: Change div to <Grid fluid></Grid>
// OPTION: add {location} as a parameter
Expand Down
2 changes: 1 addition & 1 deletion boilerplate-react/src/components/pages/HomePage.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Link } from 'react-router-dom'
const HomePage = () => (
<div>
<h1>Home Page</h1>
<Link href='/login'>Login</Link>
<Link to='/login'>Login</Link>
</div>
)

Expand Down
2 changes: 1 addition & 1 deletion boilerplate-react/src/components/pages/LoginPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class LoginPage extends Component {
return (
<div>
<h1>Login Page</h1>
<Link href='/'>Home</Link>
<Link to='/'>Home</Link>

<LoginForm submit={this.submit} />
</div>
Expand Down
9 changes: 4 additions & 5 deletions boilerplate-react/src/index.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
/* eslint-disable */

import React from 'react';
import ReactDOM from 'react-dom';
import { BrowserRouter } from 'react-router-dom';
import App from './App';
import registerServiceWorker from './registerServiceWorker';
// import LoginPage from "./components/pages/LoginPage";
import 'react-flexbox-grid/dist/react-flexbox-grid.css';

ReactDOM.render(
<BrowserRouter>
<App />
</BrowserRouter>,
document.getElementById('root')
);
// ReactDOM.render(
// <BrowserRouter><LoginPage /></BrowserRouter>,
// document.getElementById('root')
// );

registerServiceWorker();
Loading

0 comments on commit 73fb3fe

Please sign in to comment.