Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use "Save Now" and other functions not working properly #69

Closed
remysalim opened this issue Jun 22, 2016 · 10 comments · Fixed by #73
Closed

Can't use "Save Now" and other functions not working properly #69

remysalim opened this issue Jun 22, 2016 · 10 comments · Fixed by #73

Comments

@remysalim
Copy link

remysalim commented Jun 22, 2016

Basically, Local History doesn't work at all for me.
I'm not able to use any of the functions, despite the history files being present in the directory (accessed through Local History : Open Directory). It says it can't find anything

Local History not found for (...)

On 'Save Now' :

Traceback (most recent call last):
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 574, in run_
    return self.run(edit)
  File "LocalHistory in C:\Users\Me\AppData\Roaming\Sublime Text 3\Installed Packages\Local History.sublime-package", line 159, in run
NameError: global name 'view' is not defined

Also, maybe relevant maybe not, I'm working on files on a separate drive than C

@vishr
Copy link
Owner

vishr commented Jun 22, 2016

@jrappen can you look at it?

@jrappen
Copy link
Contributor

jrappen commented Jun 22, 2016

@IOMachinery

  • ST Build? OS?
  • version of Local History?

@remysalim
Copy link
Author

Sublime Text 3 Build 3114 on Windows 10 x64
Local History from Package Control, latest version I suppose 2016.06.14.22.10.34

@jrappen
Copy link
Contributor

jrappen commented Jun 24, 2016

Maybe do a rollback until I've found a solution. Local History works for me except the SaveNow text command. Which I do not understand, as the other text commands work just fine.

@konto-andrzeja
Copy link

I have exactly the same problem as the OP, but on Windows 8.1 x64.

@byaka
Copy link

byaka commented Jun 25, 2016

same problem.
Ubuntu 14.04, ST3 3114

@byaka
Copy link

byaka commented Jun 25, 2016

fix

class HistorySaveNow(sublime_plugin.TextCommand):

    def run(self, edit):
        t = Thread(target=HistorySave().process_history, args=(self.view.file_name(),))
        t.start()

@remysalim
Copy link
Author

byaka's fix is working for the Save Now issue!

In the meantime I tested the plugin with different files, and it works with any file (to my knowledge) on C: drive, but it won't find any local saves for the ones stored on my D: drive

@byaka
Copy link

byaka commented Jun 27, 2016

but it won't find any local saves for the ones stored on my D: drive

i can't check this behavior, i have no windows. Can you please post tree-structure of folders in your backup folder? And also full patch to file from D, that was backuped (for example with "save now").

and i think this problem must be separated to another issue.

@remysalim
Copy link
Author

You're right, see #72

@vishr vishr closed this as completed in #73 Jul 2, 2016
vishr pushed a commit that referenced this issue Jul 2, 2016
* fixes #69

* fixes #72

* fixes #71

* address #71

* Update LocalHistory.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants