Add proxy support to the neighbor functions #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| // TODO: seems not working because of cache |
There was a problem hiding this comment.
probably should fix this todo before merging
|
Thanks for adding this. One other thought. The iproute2 package allows you to list proxies separately. I'm wondering if we really want to include proxies by default or if it should be two separate commands? NeighList and NeighProxyList. Thoughts? |
|
I actually was thinking the same thing after I submitted the PR. Plus, no chance of breaking someone's current user cases. I'll make the changes and update the PR. |
- Don't require a MAC address for a neighbor proxy - Include proxies in the list of neighbors Signed-off-by: Zvi "CtrlZvi" Effron <viz+GitHub@flippedperspective.com>
borkmann
added a commit
to cilium/netlink
that referenced
this pull request
Oct 29, 2021
The condition to demand a lladdress for neigh.Flags != NTF_PROXY is just buggy, since there are various other flags such as NTF_USE, NTF_EXT_MANAGED, etc where this is not required. Besides, the kernel handles this internally anyway if it demands a NDA_LLADDR attribute. Simply get rid of the NTF_PROXY flag/condition since it's wrong. Fixes: d710fba ("Add proxy support to the neighbor functions (vishvananda#149)") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
vishvananda
pushed a commit
that referenced
this pull request
Nov 1, 2021
The condition to demand a lladdress for neigh.Flags != NTF_PROXY is just buggy, since there are various other flags such as NTF_USE, NTF_EXT_MANAGED, etc where this is not required. Besides, the kernel handles this internally anyway if it demands a NDA_LLADDR attribute. Simply get rid of the NTF_PROXY flag/condition since it's wrong. Fixes: d710fba ("Add proxy support to the neighbor functions (#149)") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
byteocean
pushed a commit
to byteocean/netlink
that referenced
this pull request
Nov 3, 2021
The condition to demand a lladdress for neigh.Flags != NTF_PROXY is just buggy, since there are various other flags such as NTF_USE, NTF_EXT_MANAGED, etc where this is not required. Besides, the kernel handles this internally anyway if it demands a NDA_LLADDR attribute. Simply get rid of the NTF_PROXY flag/condition since it's wrong. Fixes: d710fba ("Add proxy support to the neighbor functions (vishvananda#149)") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
cyberys
pushed a commit
to cyberys/netlink
that referenced
this pull request
Apr 5, 2022
The condition to demand a lladdress for neigh.Flags != NTF_PROXY is just buggy, since there are various other flags such as NTF_USE, NTF_EXT_MANAGED, etc where this is not required. Besides, the kernel handles this internally anyway if it demands a NDA_LLADDR attribute. Simply get rid of the NTF_PROXY flag/condition since it's wrong. Fixes: d710fba ("Add proxy support to the neighbor functions (vishvananda#149)") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
cjmakes
pushed a commit
to cjmakes/netlink
that referenced
this pull request
Jun 29, 2022
The condition to demand a lladdress for neigh.Flags != NTF_PROXY is just buggy, since there are various other flags such as NTF_USE, NTF_EXT_MANAGED, etc where this is not required. Besides, the kernel handles this internally anyway if it demands a NDA_LLADDR attribute. Simply get rid of the NTF_PROXY flag/condition since it's wrong. Fixes: d710fba ("Add proxy support to the neighbor functions (vishvananda#149)") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zvi "CtrlZvi" Effron viz+GitHub@flippedperspective.com