-
Notifications
You must be signed in to change notification settings - Fork 15.6k
-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor view engine #2217
Comments
-1. Don't see a major win by pulling out out completely. We should remove the "app.render" and clean up some code but I don't see removing it as gaining much. It can still be a module, but we should include it. |
Oh yeah separate module but still included |
👍 |
I'd love to see streaming views. Of course, that's pretty much |
If you pull out view engine, how express would be any different from connect? :) |
It means like the view engine would be a module, and |
Hmm... let me think... can I then include this view engine to my connect application, and get something like express without actually using express? :) I don't quite remember why connect had gotten rid of, but if you modularize everything, I feel a lot of feature overlap there. |
Yes.
Well, I'm not 100% of the reasoning, but I eventually want to reconsider it for 5.x. We are also going to do the same thing for the router, so it would reason that |
There was already a lot of overlap and express was pretty highly coupled to
|
Yep, that's what I figured--, though in it's current state that no longer applies. I'll push up a branch with connect 3 at the express core that we can mull over. |
I kind of made a streaming template engine a while ago called "blue" Le 10 juil. 2014 17:31, "Douglas Christopher Wilson" < notifications@github.com> a écrit :
|
what's your views on templation? if it's good enough for 5.x i'll work on it some more. some help with more templating engines as well as collabs would be great |
I have not taken a look at it just yet. |
Any progress on this? Streaming views would be pretty nice. |
This may belong in another feature ticket, but I would prefer to couple view engines with view directories together in order to accommodate handling multiple view engines and multiple view directories within a single express app. For example ... // hypothetical initialization
app.set('view engines', [
{ 'engine': 'jade', 'views': [ 'views/jade1', 'views/jade2' ] },
{ 'engine': 'handlebars', 'views': [ 'views/handlebards' ] }
]); |
it shoudl just be in its own library. i quickly hacked together https://github.com/expressjs/templation. some opinions would be nice.
a really good view engine is https://github.com/ericf/express3-handlebars, but the one express includes should be able to use most templating languages
The text was updated successfully, but these errors were encountered: