Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hash from ctx.pathname #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove hash from ctx.pathname #376

wants to merge 1 commit into from

Conversation

j0hj0h
Copy link

@j0hj0h j0hj0h commented May 26, 2016

Fixes #375 by removing hashportion of pathname the same way it's done for ctx.path.
Maybe Route.prototype.match also needs to be updated ... not sure about this.

@j0hj0h
remove hash from ctx.pathname
378a13a 
Fixes visionmedia#375 by removing hashportion of pathname the same way it's done for ctx.path.
Maybe Route.prototype.match also needs to be updated ... not sure about this.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.209% when pulling 378a13a on j0hj0h:master into aa60550 on visionmedia:master.

@matthewp
Copy link
Collaborator

Thanks @j0hj0h, any chance you can add a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j0hj0h @coveralls @matthewp