Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for the file protocol #441

Merged
merged 2 commits into from
Jan 15, 2018
Merged

Improve support for the file protocol #441

merged 2 commits into from
Jan 15, 2018

Conversation

matthewp
Copy link
Collaborator

This change improves support for using the file protocol with page.js.
Basically once you enable hashbang we treat the base as though it were
/. Fixes #209

This change improves support for using the file protocol with page.js.
Basically once you enable hashbang we treat the base as though it were
`/`. Fixes #209
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.0% when pulling 12e0189 on file-protocol into 1269035 on master.

@coveralls
Copy link

coveralls commented Jan 15, 2018

Coverage Status

Coverage increased (+0.1%) to 90.0% when pulling 17e2695 on file-protocol into 1269035 on master.

@matthewp matthewp merged commit 213b6b8 into master Jan 15, 2018
@matthewp matthewp deleted the file-protocol branch January 15, 2018 19:22
@kaisermann
Copy link
Contributor

kaisermann commented Dec 3, 2018

@matthewp Sorry for commenting on an old PR, but could you explain what the location.protocol check here does in this context? I'm trying to save the last scroll position on page.exit (by using ctx.save) but my apps use the file: protocol and I'm unable to modify (and save) the current context before going to another one.

Edit: please tell me if this is not the right way to do this 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants