Add failing quickrecipe tests to skip list. #18401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinPrivitera
approved these changes
Dec 21, 2022
brugger1
deleted the
task/brugger1/2022_12_21_fix_quickrecipe_failures
branch
|
Sheesh...sorry I wasn't paying attention to these failures. I will correct when back. @biagas mentioned one of these failing on windows too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the two quickrecipe tests that were failing to the skip list. The first failure appears to come from a missing file, perhaps it wasn't committed. The second failure is from referencing a data file that's in someone's home directory. In both cases, the problem appears to be with the tests and not VisIt, so adding them to the skip list should be fine until they can be fixed.
Type of change
How Has This Been Tested?
I haven't tested it. That will happen with the test suite run tonight.
Reminders:
Checklist:
[ ] I have commented my code where applicable.[ ] I have updated the release notes.[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.