Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heal read the docs #18681

Merged
merged 4 commits into from
May 8, 2023
Merged

heal read the docs #18681

merged 4 commits into from
May 8, 2023

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented May 5, 2023

Description

Updates Read the Docs CI config to use newer python.

Type of change

  • Bug fix~~
  • New feature~~
  • Documentation update~~
  • Other~~

CI config change.

How Has This Been Tested?

CI will test :-)

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

- [ ] I have commented my code where applicable.
- [ ] I have updated the release notes.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added debugging support to my changes.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] I have confirmed new and existing unit tests pass locally with my changes.
- [ ] I have added new baselines for any new tests to the repo.
- [ ] I have NOT made any changes to protocol or public interfaces in an RC branch.

markcmiller86
markcmiller86 previously approved these changes May 5, 2023
@cyrush
Copy link
Member Author

cyrush commented May 5, 2023

success

@cyrush cyrush merged commit aa5026a into develop May 8, 2023
@cyrush cyrush deleted the task/2023_05_heal_read_the_docs branch May 8, 2023 18:36
@markcmiller86
Copy link
Member

@cyrush remind me...why did we remove fail_on_warnings?

@JustinPrivitera
Copy link
Member

@markcmiller86 I thought you wanted to remove fail_on_warnings. I believe what started it was that I had caused a whole bunch of warnings with my automatic section labels stuff, and you thought that forcing fail_on_warnings would prevent things like that from happening in the future. I think you said that maybe it used to be like this in the past? I don't quite remember.

@markcmiller86
Copy link
Member

@markcmiller86 I thought you wanted to remove fail_on_warnings.

No. I added it back in late Feb I think to ensure nobody gets a pass in RTD build if they've introduced warnings.

@cyrush removed it here. But, he did so after I had done a review in which the only change was the python version number.

I think we want to keep fail_on_warnings. I for one am tired of building locally only to be confronted with a slew of warnings nobody was paying attention to.

@JustinPrivitera
Copy link
Member

Sorry my brain was jumbled. I had everything backwards. Yes I remember now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants