Fixed the issue with installing host profiles after moving .visit directory #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving or deleting the .visit directory while VisIt is running.
successfully copied.
cyrush
approved these changes
Nov 9, 2019
brugger1
approved these changes
Nov 9, 2019
| @@ -27,6 +27,7 @@ | |||
| <li>Fixed bug with VTK reader parsing .vtm files when 'DataSet' tag doesn't have a 'file' attribute.</li> | |||
| <li>Disable VCR play/reverse play buttons when there is not active drawn plot.</li> | |||
| <li>Fixed inability to Pick on glyphed points lying near the dataset bounds.</li> | |||
| <li>Fixed the issue with installing host profiles after deleting or moving the .visit folder while VisIt is running.</li> | |||
There was a problem hiding this comment.
Is the "while VisIt is running" necessary.
There was a problem hiding this comment.
I just realized that VisIt probably creates the ".visit" directory when it runs, so the only way it can be missing is if it deleted or moved while VisIt is running, so the clause is appropriate.
There was a problem hiding this comment.
Yes...this issue only happened when VisIt was running since the parent directories need to be recreated which mkdir didn't do. If the .visit dir is moved when VisIt is not running, during startup VisIt would create the parent directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In rare cases when the user moves or deletes their .visit directory all the directories in the path need to be recreated. The call to mkdir in the previous GetAndMakeUserVisItHostsDirectory called didn't do that and there were no checks for successful creation of the hosts directory. The call to get the hosts directory was split from making the directory so mkpath could be used to create all the parent directories if needed. Successful creation is now checked and if it fails the appropriate debug log message is created.
Resolves #3741
Type of change
Please select one below (Please click check boxes AFTER submitting ticket)
How Has This Been Tested?
Built and ran VisIt with the changes and verified that it worked.
Checklist: