Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddf ghost zones bugfix #5489

Merged
merged 2 commits into from
Feb 24, 2021
Merged

ddf ghost zones bugfix #5489

merged 2 commits into from
Feb 24, 2021

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Feb 23, 2021

Description

Resolves #5469

Fixes ddfs and data binning logic to exclude ghost zones

New tests before the fix (big versions of images)

Screen Shot 2021-02-23 at 10 48 29 AM
Screen Shot 2021-02-23 at 10 48 25 AM

After the fix:

Screen Shot 2021-02-23 at 12 54 40 PM

Type of change

Bugfix

How Has This Been Tested?

Tested with new ddf test suite test on my mac and in docker.

Checklist:

  • I have followed the style guidelines of this project.~~
  • I have performed a self-review of my own code.~~
  • I have commented my code where applicable.~~
  • I have updated the release notes.~~
    - [ ] I have made corresponding changes to the documentation.
  • I have added debugging support to my changes.~~
  • I have added tests that prove my fix is effective or that my feature works.~~
  • I have confirmed new and existing unit tests pass locally with my changes.~~
  • I have added any new baselines to the repo.~~
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~
  • I have assigned reviewers (see VisIt's PR procedures for more information).~~

@cyrush cyrush changed the title Task/2021 02 ddf gzones bugfix ddf ghost zones bugfix Feb 23, 2021
@cyrush cyrush merged commit ae35000 into develop Feb 24, 2021
@cyrush cyrush deleted the task/2021_02_ddf_gzones_bugfix branch February 24, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ddf isn't properly accounting for ghost zones
3 participants