Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pypa/cibuildwheel from 2.11.2 to 2.11.3 #2438

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 19, 2022

Bumps pypa/cibuildwheel from 2.11.2 to 2.11.3.

Release notes

Sourced from pypa/cibuildwheel's releases.

v2.11.3

  • ✨ Improves the 'build options' log output that's printed at the start of each run (#1352)
  • ✨ Added a friendly error message to a common misconfiguration of the CIBW_TEST_COMMAND option - not specifying path using the {project} placeholder (#1336)
  • 🛠 The GitHub Action now uses Powershell on Windows to avoid occasional incompabilities with bash (#1346)
Changelog

Sourced from pypa/cibuildwheel's changelog.

v2.11.3

5 Dec 2022

  • ✨ Improves the 'build options' log output that's printed at the start of each run (#1352)
  • ✨ Added a friendly error message to a common misconfiguration of the CIBW_TEST_COMMAND option - not specifying path using the {project} placeholder (#1336)
  • 🛠 The GitHub Action now uses Powershell on Windows to avoid occasional incompabilities with bash (#1346)
Commits
  • a34a6b0 Bump version: v2.11.3
  • 61b6cc8 Merge pull request #1352 from pypa/improve-preamble
  • ecce3d9 Merge pull request #1336 from pypa/test-cwd-error-message
  • 63ef1b0 Merge pull request #1366 from pypa/pre-commit-ci-update-config
  • ba9a82e [pre-commit.ci] pre-commit autoupdate
  • 46372e1 Merge pull request #1364 from pypa/dependabot/github_actions/pypa/gh-action-p...
  • a157a51 Use a unittest style test to support more test runners
  • 9850864 Rename 'environ' to 'env'
  • 56359fb Apply suggestions from code review
  • 99f62f5 build(deps): bump pypa/gh-action-pypi-publish from 1.5.1 to 1.6.1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.11.2 to 2.11.3.
- [Release notes](https://github.com/pypa/cibuildwheel/releases)
- [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md)
- [Commits](pypa/cibuildwheel@v2.11.2...v2.11.3)

---
updated-dependencies:
- dependency-name: pypa/cibuildwheel
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 19, 2022
@djhoese
Copy link
Member

djhoese commented Dec 19, 2022

@brisvag @larsoner @kmuehlbauer Any ideas:

  __________________________ test_color_interpretation ___________________________
  
      def test_color_interpretation():
          """Test basic color interpretation API"""
          # test useful ways of single color init
          r = ColorArray('r')
          print(r)  # test repr
          r2 = ColorArray(r)
          assert_equal(r, r2)
          r2.rgb = 0, 0, 0
          assert_equal(r2, ColorArray('black'))
          assert_equal(r, ColorArray('r'))  # modifying new one preserves old
          assert_equal(r, r.copy())
          assert_equal(r, ColorArray('#ff0000'))
          assert_equal(r, ColorArray('#FF0000FF'))
          assert_equal(r, ColorArray('red'))
          assert_equal(r, ColorArray('red', alpha=1.0))
          assert_equal(ColorArray((1, 0, 0, 0.1)), ColorArray('red', alpha=0.1))
          assert_array_equal(r.rgb.ravel(), (1., 0., 0.))
          assert_array_equal(r.rgba.ravel(), (1., 0., 0., 1.))
          assert_array_equal(r.RGBA.ravel(), (255, 0, 0, 255))
      
          # handling multiple colors
          rgb = ColorArray(list('rgb'))
          print(rgb)  # multi repr
  >       assert_array_equal(rgb, ColorArray(np.eye(3)))
  
  vispy/color/tests/test_color.py:93: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  
  args = (<built-in function eq>, <ColorArray: 3 colors ((1.0, 0.0, 0.0, 1.0) ... (0.0, 0.0, 1.0, 1.0))>, <ColorArray: 3 colors ((1.0, 0.0, 0.0, 1.0) ... (0.0, 0.0, 1.0, 1.0))>)
  kwds = {'err_msg': '', 'header': 'Arrays are not equal', 'strict': False, 'verbose': True}
  
      @wraps(func)
      def inner(*args, **kwds):
          with self._recreate_cm():
  >           return func(*args, **kwds)
  E           ValueError: setting an array element with a sequence. The requested array would exceed the maximum number of dimension of 32.

We're using oldest-supported-numpy in the wheel builds so it isn't clear to me why this would start failing all of a sudden in a normal Python 3.8 build (from what I can tell).

@brisvag
Copy link
Collaborator

brisvag commented Dec 20, 2022

We're having a bunch of errors due to a numpy update in napari too... but if we're using the oldest here, that's indeed odd :/

@larsoner
Copy link
Member

We're using oldest-supported-numpy in the wheel builds so it isn't clear to me why this would start failing all of a sudden in a normal Python 3.8 build (from what I can tell).

We're having a bunch of errors due to a numpy update in napari too... but if we're using the oldest here, that's indeed odd :/

Using the oldest to build does not necessarily seem to imply the oldest will be used during testing, according to the log it's using NumPy 1.24 so that's probably what the problem is, some change of behavior there:

https://github.com/vispy/vispy/actions/runs/3731263781/jobs/6329292633#step:4:4979

That's what I'd suggest looking into...

@djhoese
Copy link
Member

djhoese commented Dec 21, 2022

See #2439 for my approach at a fix.

@djhoese djhoese merged commit 11a8c5d into main Dec 21, 2022
@djhoese djhoese deleted the dependabot/github_actions/pypa/cibuildwheel-2.11.3 branch December 21, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants