Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-failure in stackage nightly build #30

Closed
bergmark opened this issue Mar 6, 2017 · 4 comments
Closed

test-failure in stackage nightly build #30

bergmark opened this issue Mar 6, 2017 · 4 comments

Comments

@bergmark
Copy link

bergmark commented Mar 6, 2017

It's not clear to me how serious this is so I'm marking the test suite as an expected failure for now, please let me know if we should keep it like that or if it can/will be fixed.

> /tmp/stackage-build14/language-c-0.6$ dist/build/language-c-harness/language-c-harness
Changing to test directory test/harness and compiling
make: *** No rule to make target 'prepare'.  Stop.
language-c-harness: callProcess: make "prepare" (exit 2): failed
@lambdageek
Copy link

@visq I think this is happening because language-c.cabal doesn't include any of the files under test/harness/* as extra-source-files. So if you do cabal get language-c and then ls test/harness the only file that's shipped is run-harness.hs.

(Our .travis.yml doesn't test for that because it only does a cabal install from a source tarball, not a cabal build && cabal test && cabal install)

@visq
Copy link
Owner

visq commented Mar 7, 2017

@bergmark
I see, thanks. We'll ensure the test works from the dist tarball and then I'll upload language-c 0.6.1 or 0.7.0.
@lambdageek
So extra-source-files should do the trick? It would be cool if travis.yml tested the dist tarball.

@visq
Copy link
Owner

visq commented Mar 7, 2017

@lambdageek
Hmm, there is a lot that we would have to bundle for testing (examples, test framework, harness; I'm currently adding dg parse tests to the harness). I think it would be easier to disable the test if we are out of the source tree, and leave .travis.yml as is.

@lambdageek
Copy link

@visq I agree it's probably more expedient to have the harness disabled if running from a tarball - cabal doesn't make it easy to include a lot of extra source files, and while it would be nice to be able to test with a tarball, it would be a pain to maintain.

@visq visq closed this as completed in d50dae3 Mar 7, 2017
bergmark added a commit to commercialhaskell/stackage that referenced this issue Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants