Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gulpfile optimisations #396

Merged
merged 4 commits into from Jun 7, 2019
Merged

Conversation

khawkins98
Copy link
Contributor

@khawkins98 khawkins98 commented Jun 6, 2019

This does a couple things:

  1. Namespaces the gulp commands so that they won't conflict if the gulpfile is being included in another project
    • also updates docs to say "use gulp vf-dev"
  2. Makes better use of variables to set the component path for sass, js, etc.

Both of these will be of particular importance to things like vf-eleventy ... a separate PR to come there.

Keeping this as a draft until the vf-eleventy stuff is prepped.

@auto-comment
Copy link

auto-comment bot commented Jun 6, 2019

Have you added any relevant labels to this PR?
To help this process please make sure you have these things ready (if applicable).

  • package.json updated accordingly. - [ ] README.md fill out with required documentation. - [ ] any .scss files correctly documented. - [ ] a detailed outlin on what this PR is expected to do

@auto-comment
Copy link

auto-comment bot commented Jun 6, 2019

Thank you for requesting a review for this pull request (PR).
If this PR has an associated issue - please add that to the PR description.
If you have not done so already - please fill out the PR description with as much context as possible.

@sturobson
Copy link

as in you're in gulpfile.js do you want to take on #324 as I've not assigned it to me yet?

@khawkins98
Copy link
Contributor Author

👍 snagged that task and assigned to myself.

@sturobson sturobson marked this pull request as ready for review June 7, 2019 08:29
@sturobson sturobson merged commit c3be1ce into develop Jun 7, 2019
@sturobson sturobson deleted the feature/gulpfile-optimisations branch June 7, 2019 08:34
khawkins98 added a commit to visual-framework/vf-welcome that referenced this pull request Jun 11, 2019
Ties in with visual-framework/vf-core#396 (tweaks to the vf-core gulpfile) to allow dynamic component-usage based CSS builds within vf-eleventy
@khawkins98 khawkins98 mentioned this pull request Jun 18, 2019
7 tasks
@khawkins98 khawkins98 added this to the v2.0.0-alpha.6 milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
VF v2.0.0-beta.1
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants