Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gulpfile optimisations #396

Merged
merged 4 commits into from Jun 7, 2019
Merged

Feature/gulpfile optimisations #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca523b0
Namespace all gulp commands with `vf-`
khawkins98 Jun 6, 2019
e4d0f2f
Use component path variable
khawkins98 Jun 6, 2019
4ed3c34
Considerations for things in `vf-core-components`
khawkins98 Jun 6, 2019
edc7eb3
Keep it DRY and don't genCSS on the rollup
khawkins98 Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Expand Up @@ -35,7 +35,7 @@ build:
script:
- npm install
- npm install -g gulp-cli
- gulp build
- gulp vf-build
artifacts:
paths:
- build
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ stages:
before_script:
- npm install
- npm install -g gulp-cli
- gulp build
- gulp vf-build
- "curl https://www.projectwallace.com/webhooks/v1/imports?token=$WALLACE_TOKEN -fsS --retry 3 -X POST -H 'Content-Type: text/css' -d @build/css/styles.css"

deploy:
Expand Down
4 changes: 2 additions & 2 deletions docs/contributing/creating-new-components.njk
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ This codebase includes a folder and file creation tool. It allows you to quickly
- If you've come this far and you don't have `yo`, you should be able to install it with `npm install -g yo@latest`
- If you get stuck, [see the official install guide](http://yeoman.io/codelab/setup.html)
1. Create a new component
- Run `gulp component` and answer the questions when prompted.
- Run `gulp vf-component` and answer the questions when prompted.
- **Type of component:** We use a variation of the atomic design methodology, [read about the differences here](http://bradfrost.com/blog/post/atomic-web-design/#atoms). We use: elements, blocks, and containers.
- an element would be a heading, or a button
- a block would be a teaser, or a search form
Expand All @@ -21,7 +21,7 @@ This codebase includes a folder and file creation tool. It allows you to quickly
1. Add the `@import 'vfc-your-component.scss';` to `/assets/scss/styles.scss`.
1. Developing your component
- Edit your template files in the `/components/your-component-name` folder
- Run `gulp dev` to compile and preview the component
- Run `gulp vf-dev` to compile and preview the component
1. Sharing you component back
- Publish it to npm; or
- If you think your component is of use to the wider `vf-core` community, [make a Pull Request](https://github.com/visual-framework/vf-core/pulls).
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/setting-up.njk
View file
Open in desktop
Expand Up @@ -44,4 +44,4 @@ You will need to install this repo onto your machine so that you can update, ame
1. Download all the things
- `npm install`
1. Run a dev build and open in your browser
- `gulp dev`
- `gulp vf-dev`