Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: don't send backstop files to npm #432

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

khawkins98
Copy link
Contributor

Just a cleanup thing I suppose.

Just a cleanup thing I suppose.
@auto-comment
Copy link

auto-comment bot commented Jun 24, 2019

Thank you for requesting a review for this pull request (PR).
If this PR has an associated issue - please add that to the PR description.
If you have not done so already - please fill out the PR description with as much context as possible.

@auto-comment
Copy link

auto-comment bot commented Jun 24, 2019

Have you added any relevant labels to this PR?
To help this process please make sure you have these things ready (if applicable).

  • package.json updated accordingly. - [ ] README.md fill out with required documentation. - [ ] any .scss files correctly documented. - [ ] a detailed outlin on what this PR is expected to do

@sturobson
Copy link

Ideally - I think we need to look to Percy.

Taking them out of version control could lead to some false positives and some negative errors(?) as each rendering of the images could be different from machine to machine.

I can look at Percy a bit more this week.

For now - let's merge this in - with the end game of off-loading this to a CI task

@sturobson sturobson merged commit 09df7d6 into develop Jun 24, 2019
@sturobson sturobson deleted the chore/dont-send-backstop-files-to-npm branch June 24, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants