Clean up and dependency path fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skidau
added a commit
that referenced
this pull request
Jun 11, 2015
Clean up and dependency path fixes
Closed
rkitover
pushed a commit
that referenced
this pull request
Jan 29, 2019
1. EEPROM: move eepromInUse and eepromSize from EepromReset() to eepromInit() to avoid re-initializing during a reset (makes item below redundant) 2. Remove gbaSaveType variable - this is now redundant due to change above which probably was added for this reason since games using eeprom fails with gamepak error after a reset. 3. Add labels to identify cpuSaveTypes 4. libretro: remove workaround for eeprom reset issue (#1), do not apply custom gbPalettes if not running in GB, change vram size to 0x18000 in memory map
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
1 task
rkitover
pushed a commit
that referenced
this pull request
Apr 12, 2024
The CPSR register needs to be restored from SPSR when switching modes. This is currently being done for all mode switches /except/ for FIQ, which is very likely just an oversight rather than intended behaviour. This fixes the random crashing in OpenLara, as well as fixing random glitching of my own project that uses FIQ mode switches. The issue happens "at random" because it requires an interrupt to occur while in FIQ mode, and it must also fire inside a section of code that relies on the status flags (or the CPSR register in general): When exiting the interrupt exception, the CPSR register is supposed to be restored from SPSR, but this isn't being done when switching from IRQ mode back to FIQ mode, which results in CPSR (and thus the status flags) being corrupted. For example, SUBS r0, #1; [interrupt]; BNE 1b would trigger the bug, but [interrupt]; SUBS r0, #1; BNE 1b wouldn't, and neither would SUBS r0,#1; BNE 1b; [interrupt].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.