Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCC warnings, incorrect c flag, wrong return type #74

Merged
merged 7 commits into from Feb 13, 2017

Conversation

@Mystro256
Copy link
Contributor

Mystro256 commented Feb 12, 2017

Some misc fixes:

  • Fix some GCC warnings and added some error cases/checking
  • fpermissive is not a C flag, only a c++ flag. I've removed it to silence a warning.
  • cheatsImportGSACodeFile incorrectly returns false in non-error case, should be true for success (see src/wx/cmdevents.cpp). Caused an incorrect error code to print.
@rkitover rkitover force-pushed the Mystro256:gccwarnings branch from 1544841 to 28624ac Feb 12, 2017
Add -fpermissive and -fexceptions to CMAKE_CXX_COMPILE_OBJECT so that
they only affect C++. -std=gnu++11 was already there from b4ba9d9, but
this is a cleaner method (which is also used for NASM) where we use
STRING(REGEX REPLACE ...) to append options after the <FLAGS>
placeholder in CMAKE_CXX_COMPILE_OBJECT.
@rkitover

This comment has been minimized.

Copy link
Collaborator

rkitover commented Feb 12, 2017

@Mystro256 I rebased and added a small commit (-fpermissive is required on Ubuntu 14 or Debian 8, I forget which, I put it in C++ flags only.)

Please check that everything is OK and I will merge.

@rkitover

This comment has been minimized.

Copy link
Collaborator

rkitover commented Feb 12, 2017

@Mystro256 also, can you please check if any of your changes fix either #62 or #63.

@rkitover rkitover added the bug label Feb 12, 2017
@Mystro256

This comment has been minimized.

Copy link
Contributor Author

Mystro256 commented Feb 13, 2017

Looks good.

As well, I only changed the code when loading cheats and patches from file, while those issues seem to be runtime and GUI enhancement requests.

@rkitover rkitover added the fixed label Feb 13, 2017
@rkitover rkitover merged commit 99c6c4f into visualboyadvance-m:master Feb 13, 2017
rkitover pushed a commit that referenced this pull request Aug 15, 2019
Fix "index out of bounds" runtime error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.