Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcodes don't work #25

Closed
rylanb opened this issue Nov 7, 2016 · 4 comments
Closed

Shortcodes don't work #25

rylanb opened this issue Nov 7, 2016 · 4 comments

Comments

@rylanb
Copy link

rylanb commented Nov 7, 2016

Hello,
Great gem! I'm liking it so far. I'm curious if short codes are supported? I'm using this for a soon to launch app and getting this error:

Twilio::REST::RequestError: The 'From' number + is not a valid phone number, shortcode, or alphanumeric sender ID.

When trying with 89045 format style of number as we have a short code we are trying to send messages from. Any thoughts or ideas here?

I'd posit that phone_with_plus(phone) tries to add a + to it.

If I add a '+89045' I get the + error. If I try to pass in '89045' I get an error that the from is blank.

Any thoughts or guidance here?

Thanks!

@philnash
Copy link
Contributor

philnash commented Nov 7, 2016

Hey @rylanb, I saw your issue and thought I'd try to fix it. Check out the PR in #26 and see whether that works for you.

@rylanb
Copy link
Author

rylanb commented Nov 7, 2016

👍

@rylanb
Copy link
Author

rylanb commented Nov 7, 2016

Testing on staging now and works locally pointing at your repo/branch.

@Marahin
Copy link
Contributor

Marahin commented Dec 6, 2017

Closing the issue as #39 is the successor of #26 that will be included in the upcoming release.

@Marahin Marahin closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants