Resolves Multiple Issues and Enhances Docker Setup #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thon version The apt-get install command was not properly installing the desired python version due to the quotes being removed from the package names. This commit adds quotes to the package names to ensure that the correct version of python is installed.
… config file The command to extract the python version from the config file was incorrect. The cut command was used instead of cat to extract the value of the python version. The cut command was updated to extract the value of the python version from the config file.
The Dockerfile has been updated to include the installation of npm and ungit. This is useful for development purposes as it allows developers to easily visualize and manage their git repositories.
The tree package has been added to the Dockerfile to improve the development experience by allowing developers to easily visualize the directory structure of the project.
vitabaks
reviewed
May 28, 2023
vitabaks
reviewed
May 28, 2023
…them to install the specified versions The Dockerfile now includes two variables, NPM_VERSION and UNGIT_VERSION, which are used to install the specified versions of npm and ungit respectively. This allows for easier version management and ensures that the correct versions are installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses and closes several issues:
Close #341
Close #340
Close #327
Close #326
To ensure the stability of the changes made, a series of tests have been successfully carried out. These include:
make docker-lintto check code consistency and adherence to style guidelinesmake docker-buildto verify that the Docker image builds without any errors or issues