Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Hadolint Linter Issues in .config/gitpod/Dockerfile #326

Closed
ThomasSanson opened this issue May 6, 2023 · 0 comments · Fixed by #352
Closed

Correct Hadolint Linter Issues in .config/gitpod/Dockerfile #326

ThomasSanson opened this issue May 6, 2023 · 0 comments · Fixed by #352

Comments

@ThomasSanson
Copy link
Contributor

Hello,

I've come across an issue in the .config/gitpod/Dockerfile file that needs to be addressed to improve code quality and maintainability. Here's a brief explanation of the changes that should be made:

  1. Add a shell option for pipefail:
    It is recommended to add the pipefail option to the shell command to ensure that if any command in a pipeline fails, the entire pipeline will fail. This helps avoid unexpected behavior and makes error handling more straightforward.

  2. Ignore DL3008 and DL3013 Hadolint rules:
    These rules, while useful in some cases, can be too strict in certain situations. For this project, it would be better to ignore these specific rules to avoid unnecessary complications.

Here's the proposed change for the .config/gitpod/Dockerfile file:

...
SHELL ["/bin/bash", "-o", "pipefail", "-c"]

# Update system and install packages, including Docker
# hadolint ignore=DL3008,DL3013
RUN apt-get update \
...

Please let me know your thoughts on this proposal or if there's anything else that needs to be considered.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant