dispatchAsync method #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalets
requested changes
Sep 29, 2016
| * Call all listeners with specified params asynchronously | ||
| */ | ||
| dispatchAsync(...args) { | ||
| setTimeout(() => this.dispatch(...args), 0); |
There was a problem hiding this comment.
I suggest to run each listener in own setTimeout. The benefit is that if there is error on one listenres all other will be called anyway.
There was a problem hiding this comment.
Ok. Done it. Also add dispatchAsync calls accumulation, when channel is muted
- each listener called via its own setTimeout - accumulate async calls, when channel is muted
vitalets
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vitalets