Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pipe function into explicit sync and async versions #132

Merged
merged 6 commits into from
Oct 2, 2022

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Oct 1, 2022

As discussed in #131

The original pipe function has not been removed, it just is no longer able to infer types automatically.

@vitaly-t
Copy link
Owner

vitaly-t commented Oct 1, 2022

This will need to be updated to cater for the previous PR ;)

@RebeccaStevens RebeccaStevens force-pushed the operation-split branch 6 times, most recently from 22819b1 to 974254c Compare October 2, 2022 12:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Base: 99.70% // Head: 99.40% // Decreases project coverage by -0.29% ⚠️

Coverage data is based on head (00a5ebe) compared to base (21f39cb).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   99.70%   99.40%   -0.30%     
==========================================
  Files          42       42              
  Lines        1334     1339       +5     
  Branches      278      278              
==========================================
+ Hits         1330     1331       +1     
- Misses          2        3       +1     
- Partials        2        5       +3     
Impacted Files Coverage Δ
src/types/index.ts 100.00% <ø> (ø)
src/pipe.ts 91.30% <87.50%> (-8.70%) ⬇️
src/helpers.ts 97.36% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/ops/async/delay.ts 100.00% <100.00%> (ø)
src/ops/async/retry.ts 100.00% <100.00%> (ø)
src/ops/async/throttle.ts 100.00% <100.00%> (ø)
src/ops/async/wait.ts 100.00% <100.00%> (ø)
src/ops/count.ts 100.00% <100.00%> (ø)
src/ops/every.ts 100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vitaly-t
Copy link
Owner

vitaly-t commented Oct 2, 2022

Is this one now ready for the merge?

I'm seeing some conflicts now, after previous PR-s were merged.

@RebeccaStevens
Copy link
Collaborator Author

There's a bit more to do with regards to types but I might do that in another PR.
A bunch more tests should be added too (specifically to test types) but that's probably another PR too.
I guess it should be all good to merge this one.

@RebeccaStevens RebeccaStevens marked this pull request as ready for review October 2, 2022 15:28
@vitaly-t vitaly-t merged commit d2dc0aa into vitaly-t:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants