-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split pipe
function into explicit sync and async versions
#132
Conversation
1b88e6c
to
5fb6eff
Compare
This will need to be updated to cater for the previous PR ;) |
22819b1
to
974254c
Compare
Codecov ReportBase: 99.70% // Head: 99.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 99.70% 99.40% -0.30%
==========================================
Files 42 42
Lines 1334 1339 +5
Branches 278 278
==========================================
+ Hits 1330 1331 +1
- Misses 2 3 +1
- Partials 2 5 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm seeing some conflicts now, after previous PR-s were merged. |
974254c
to
00a5ebe
Compare
There's a bit more to do with regards to types but I might do that in another PR. |
As discussed in #131
The original
pipe
function has not been removed, it just is no longer able to infer types automatically.