-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import NIDs from misc locations #390
Conversation
Note that only NIDs with name starting with 'vsh', '_vsh', 'sce', '_sce', '__sce', '___sce', 'ksce', and not containing '_unk' have been kept
db.yml
Outdated
@@ -2982,6 +3566,9 @@ modules: | |||
sceSblGcAuthMgrMsSaveBBCipherFinal: 0xEB02F15D | |||
sceSblGcAuthMgrMsSaveBBMacUpdate: 0xEE2D40F7 | |||
sceSblGcAuthMgrPcactActivation: 0x17C0CEF4 | |||
sceIoClose: 0xF5C6F098 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conflicts with SceIofilemgr
.
Alright now CI passes. I will merge this pull request if nobody makes comments today. |
dont merge because I've updated wiki and it misses a lot of pages that were not parsed. |
It's alright you can do a new pull request to add extra stuff once it's merged. |
|
@TheOfficialFloW. I remember that this function had wrong NID in vitasdk db.yml. |
I can confirm, the only open-source plugins using this function are not importing it but using |
@TheOfficialFloW @CelesteBlue-dev @devnoname120 I agree FloW's opinion. |
@d3m3vilurr The function definition will be correct once this pull request is merged. Before this pull request it wasn't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. but when merge this pr, please update/reduce commit message.
IMHO, this pr description is contained meanless messages.
GitHub doesn't have spoilers unfortunately, and I think that the extraction log is useful for accountability. |
I don't think so. you might got the information from log message, but next devs can't get extra information from full logs. I was double checked your word. very long time ago, github set the pr message into their merge message. but now they didn't. so you are right. |
@yne I can't get code nested in spoiler to work. Feel free to edit my top message if you find a way. |
I'm using
db_lookup.yml
as a reference for library and module names and nids.PSVita 3.60 NIDs from syslibtrace
https://pastebin.com/ZAfpHwEH
3.60 Vita NIDs
https://pastebin.com/G0q01WjB
This nid list didn't add any NIDs in
db.yml
which is why there is no commit for this.NIDs from wiki.henkaku.xyz
Wiki was scraped using this running
./henkaku_wiki_scraper.py aggressive > nids.txt
.