-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip waiting check #306
Conversation
✅ Deploy Preview for vite-plugin-pwa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@mastercoms thanks a lot, looks like you've found the ghost of |
@mastercoms can you change also this code (replace the EDIT: I've included it transformIndexHtml: {
enforce: 'post',
transform(html) {
if (options.disable)
return html
// if virtual register is requested, do not inject.
if (options.injectRegister === 'auto')
options.injectRegister = useImportRegister ? null : 'script'
return injectServiceWorker(html, options)
},
}, |
If the virtual module is not being called, then the `registerSW.js` is generated, but the `transform` hook on `tranformIndexHtml` is being called before `generateBundle` and so we also need to check it on that hook
to test it use the cdn example, just remove the you can also run some example, from root folder run |
No description provided.