Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom sw without injection point #390

merged 7 commits into from Dec 12, 2022


Copy link

@userquin userquin commented Oct 9, 2022

closes #385

Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit d41af9f
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin marked this pull request as draft October 9, 2022 20:31
@userquin userquin requested a review from antfu October 9, 2022 20:35
@userquin userquin marked this pull request as ready for review October 9, 2022 20:35
Copy link
Member Author

userquin commented Oct 16, 2022

@antfu Added simple example with a default preset for navigation, assets and images: it is the default from Nuxt (I'm working also to include an integration module for Nuxt).

I need to add some docs, using the sw this way the custom sw should be versioned to detect changes: in the example I just include a timestamp. I think using it with prompt makes no sense, that's why Nuxt always force client claims on the sw template (auto update strategy here).

@antfu antfu merged commit e500d1a into main Dec 12, 2022
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

allow use custom sw without injection point
2 participants