Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support Vite 5 #598

Merged
merged 8 commits into from
Nov 18, 2023
Merged

feat!: support Vite 5 #598

merged 8 commits into from
Nov 18, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Nov 18, 2023

This PR includes:

  • support for Vite 5 (and Rollup 4)
  • bump tests to Vitest 1.0.0 beta 4
  • update logic for dontCacheBustURLsMatching since Rollup 4 has changed assets name layout: [v4.0] feat: implement hashing content in Rust rollup/rollup#5155
  • use CJS for the plugin: the d.cts was generated: split default exports to use import and require entries

Right now all tests green running nr test with Node 20.9.0.

imagen

Copy link

netlify bot commented Nov 18, 2023

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit 0a72583
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/6558eb80a3cd05000806aabd
😎 Deploy Preview https://deploy-preview-598--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin userquin marked this pull request as ready for review November 18, 2023 13:06
@userquin userquin requested a review from antfu November 18, 2023 13:06
@userquin userquin marked this pull request as draft November 18, 2023 13:41
@userquin userquin marked this pull request as ready for review November 18, 2023 13:45
@userquin userquin marked this pull request as draft November 18, 2023 14:32
@userquin userquin marked this pull request as ready for review November 18, 2023 16:41
@userquin userquin marked this pull request as draft November 18, 2023 16:53
@userquin userquin marked this pull request as ready for review November 18, 2023 17:00
@userquin userquin merged commit 54b7ab9 into main Nov 18, 2023
4 checks passed
@userquin userquin deleted the userquin/feat-vite5-support branch November 18, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants