New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refactor ssr #166
Merged
Merged
docs: refactor ssr #166
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
07370ad
docs: refactor ssr
brillout f41df5f
docs: create separate sections for Frameworks and Boilerplates
brillout 1e06f27
docs: add links to SSR frameworks section + remove SSR Boilerplates s…
brillout f86c9b6
docs: improve SSR frameworks note.
brillout df6bace
docs: update SSR framework hash link
brillout File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we extract SSR into another section, maybe it's better to add a line saying that "Refer to the SSR section for SSR supports"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like, I might look into the Vue section and trying to find the SSR support for Vue. But now we move it to another section, which might confuse ppl like "Oh Vite does not support SSR for Vue?" or some sort of the things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I've decided to remove the SSR Boilerplates section because the whole idea here is to let users know about higher-level alternatives to Vite's native SSR API; boilerplates are not contributing here.