Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vite-react-template and vite-rome #703

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

naqibhishamuddin
Copy link

Please make sure all the requirements are satisfied, otherwise the PR could be closed without further notice.

Checklist

  • Title as described.
  • Make sure you put things in the right category.
  • The description of your item should be a sentence with less than 24 words.
  • Avoid using links and parentheses in description.
  • Omit unnecessary words already provided in the context (e.g. for Vite, a Vite plugin).
  • Use proper case for terms (e.g. GitHub, TypeScript, ESLint, etc.)
  • When mentioning tools, omit versions whenever possible (e.g. use TypeScript instead of TypeScript 4.x, but keep Vue 2 and Vue 3 as they're incompatible).
  • When mentioning package names, use quotes whenever possible.
  • Always add your items to the end of a list.

Plugins/Tools

  • The plugin/tool is working with Vite 2.x and onward.
  • The project is Open Source.
  • The project follows the Vite Plugins Conventions.
  • The plugin uses Vite-specific hooks and can't be implemented as a Compatible Rollup Plugin.
  • The repo should be at least 30 days old.
  • The documentation is in English.
  • The project is active and maintained (inactive projects for longer 6 months will be removed without further notice).
  • The project accepts contributions.
  • Not a commercial product.

Starter Templates

  • The starter template is working with Vite 2.x and onward.
  • The documentation is in English.
  • The starter template must provide enough instructions / documentation about how to start up and what's included.
  • A screenshot or a live demo should be included.
  • The repo should be at least 30 days old.
  • Should be differentiable from the existing starter templates.

Apps/Websites

  • The website is available without errors and load in a reasonable amount of time.
  • The website must be Open Source and showing it's using Vite intensively.
  • The website is original and not too simple. For that reason, blogs and simple landing pages are rejected.

@naqibhishamuddin
Copy link
Author

Heyya @Scrum , may I know the updates for this PR ? Thanks ! 😄

@Scrum
Copy link
Collaborator

Scrum commented Jun 2, 2023

need resolve

@naqibhishamuddin
Copy link
Author

Heyya @Scrum , I already resolve the conflicts 🎉

Copy link
Collaborator

@Scrum Scrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the last on the list & description must end with proper punctuation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants