Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch from yarn to pnpm #1256

Closed
wants to merge 1 commit into from

Conversation

NozomuIkuta
Copy link
Contributor

resolve #1249

This is my very first PR to this repository.
I might be missing something important.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for vitejs-docs-ja failed.

Name Link
🔨 Latest commit bee5793
🔍 Latest deploy log https://app.netlify.com/sites/vitejs-docs-ja/deploys/65786c169822200008422d30

- name: Run textlint
run: yarn lint
run: pnpm run lint
Copy link
Contributor Author

@NozomuIkuta NozomuIkuta Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not use short syntax like pnpm lint based on conversation in the upstream repository (vitejs/vite#5060 (comment)).

@NozomuIkuta
Copy link
Contributor Author

NozomuIkuta commented Dec 12, 2023

@jay-es

Please take over this PR and fix Netlify configuration to pass CI.

@jay-es
Copy link
Collaborator

jay-es commented Dec 13, 2023

@NozomuIkuta Thank you very much!
I imported your commit into my local repository, fix the lint action, and created a new PR #1257.
Is this the right way?

@kazupon Excuse me.
I don't have access to Netlify, so please invite me.
Or could you change the build command for the site to pnpm.

@NozomuIkuta
Copy link
Contributor Author

Thank you for taking it over.
I will check your PR later.

Let me close this PR for now.

@NozomuIkuta NozomuIkuta deleted the chore/switch-to-pnpm branch December 13, 2023 15:05
@kazupon
Copy link
Contributor

kazupon commented Dec 14, 2023

@jay-es netlify ですが、viteの方は自分入っていないので権限周りいじれないです。🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO: pnpm に切り替え
3 participants