chore: switch from yarn to pnpm
#1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitejs-docs-ja ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NozomuIkuta
reviewed
Dec 13, 2023
.github/workflows/lint.yml
Outdated
Comment on lines
12
to
17
| - uses: pnpm/action-setup@v2.4.0 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
| - name: Install deps | ||
| run: yarn | ||
| run: pnpm install |
There was a problem hiding this comment.
Thank you for fixing it.
You could also add cache management to reduce installation time according to the official docs.
There was a problem hiding this comment.
@NozomuIkuta
I changed it to the simpler cache settings on the official website.
https://pnpm.io/continuous-integration#github-actions
And Kia-san changed the Netlify settings!
There was a problem hiding this comment.
I've never used the cache option of the GitHub action, and not so sure what will happen.
Anyway, we could change it later if something is wrong.
Let's merge and check if it works. 👍
NozomuIkuta
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1249