chore: refactor runPluginOverrides #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
reviewed
Mar 30, 2023
Comment on lines
+219
to
+192
| const newBabelOptions = createBabelOptions( | ||
| typeof opts.babel === 'function' | ||
| ? opts.babel(id, { ssr }) | ||
| : opts.babel, |
There was a problem hiding this comment.
We lost an optimization here, if opts.babel isn't a function, createBabelOptions can be created upfront and cached.
There was a problem hiding this comment.
I kept it when there is not plugin overrides.
When there are one, I think it's safer to re-create one because it mutates the object
patak-dev
approved these changes
Mar 30, 2023
ArnaudBarre
force-pushed
the
chore/refactor-plugin-overrides
branch
from
d1bdd05
to
8b116bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nested callback and the boolean returns confused me.
I prefer to have the run callback optional and use an iife for setup the babelPlugins so I this doesn't need a temporary let and there is one less branch