Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set vite to be optional #184

Closed

Conversation

StarFishing
Copy link

Description

Additional context

If vite is not necessary, can use this PR


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ArnaudBarre
Copy link
Member

I don't understand what's the usecase for using this plugin wihtout Vite?

@StarFishing
Copy link
Author

I don't understand what's the usecase for using this plugin wihtout Vite?

Used in conjunction with vitest as plugins. I'm not sure if this is appropriate.

@ArnaudBarre
Copy link
Member

Vitest is using Vite under the hood (that's why you can use vite plugins).

BTW for testing only this plugin my not be necessary if you don't use babel plugins as esbuild will take care of jsx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants