feat: allow boolean attr values in html transform tag descriptors (#1381

)
vitejs · Jan 5, 2021 · 0fad96e · 0fad96e
1 parent 724aa8a
commit 0fad96e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/docs/guide/api-plugin.md b/docs/guide/api-plugin.md
@@ -263,7 +263,7 @@ Vite plugins can also provide hooks that serve Vite-specific purposes. These hoo
 
   interface HtmlTagDescriptor {
     tag: string
-    attrs?: Record<string, string>
+    attrs?: Record<string, string | boolean>
     children?: string | HtmlTagDescriptor[]
     /**
      * default: 'head-prepend'

diff --git a/packages/vite/src/node/plugins/html.ts b/packages/vite/src/node/plugins/html.ts
@@ -303,7 +303,7 @@ export function buildHtmlPlugin(config: ResolvedConfig): Plugin {
 
 export interface HtmlTagDescriptor {
   tag: string
-  attrs?: Record<string, string>
+  attrs?: Record<string, string | boolean>
   children?: string | HtmlTagDescriptor[]
   /**
    * default: 'head-prepend'
@@ -484,7 +484,11 @@ function serializeTags(tags: HtmlTagDescriptor['children']): string {
 function serializeAttrs(attrs: HtmlTagDescriptor['attrs']): string {
   let res = ''
   for (const key in attrs) {
-    res += ` ${key}=${JSON.stringify(attrs[key])}`
+    if (typeof attrs[key] === 'boolean' && attrs[key]) {
+      res += ` ${key}`
+    } else {
+      res += ` ${key}=${JSON.stringify(attrs[key])}`
+    }
   }
   return res
 }