Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve cleanUrl util #12573

Merged
merged 1 commit into from
Mar 25, 2023
Merged

perf: improve cleanUrl util #12573

merged 1 commit into from
Mar 25, 2023

Conversation

patak-dev
Copy link
Member

Description

We use this util a lot, so worth improving. I did this in #12572, extracting it in a separate PR so we can merge it. I think we should move forward with #12572 but there are new ecosystem-ci tests failing for it. Maybe better to wait for Vite 5 or check Astro and Iles if you think it is worth having this in 4.3.

perf.link


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Mar 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the performance Performance related enhancement label Mar 25, 2023
@bluwy
Copy link
Member

bluwy commented Mar 25, 2023

It looks like the third test-case is faster for me on perflink (and jsbench). Though I like the readability of the regex version more

@patak-dev
Copy link
Member Author

Interestingly, on my machine, the regex version is generally faster.

@patak-dev patak-dev enabled auto-merge (squash) March 25, 2023 08:37
@patak-dev patak-dev merged commit 68d500e into main Mar 25, 2023
@patak-dev patak-dev deleted the perf/improve-cleanUrl branch March 25, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants