perf: improve cleanUrl util #12573
Merged
perf: improve cleanUrl util #12573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
approved these changes
Mar 25, 2023
|
It looks like the third test-case is faster for me on perflink (and jsbench). Though I like the readability of the regex version more |
|
Interestingly, on my machine, the regex version is generally faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use this util a lot, so worth improving. I did this in #12572, extracting it in a separate PR so we can merge it. I think we should move forward with #12572 but there are new ecosystem-ci tests failing for it. Maybe better to wait for Vite 5 or check Astro and Iles if you think it is worth having this in 4.3.
perf.link
What is the purpose of this pull request?