Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public assets with special chars are not served #1426

Closed
jods4 opened this issue Jan 8, 2021 · 1 comment · Fixed by #1432
Closed

Public assets with special chars are not served #1426

jods4 opened this issue Jan 8, 2021 · 1 comment · Fixed by #1432
Labels
pending triage

Comments

@jods4
Copy link
Contributor

jods4 commented Jan 8, 2021 •
edited
Loading

Describe the bug

Static assets referenced by encoded URLs are not served.

Reproduction

  1. Create a file /public/Hello World.css on your disk
  2. Run Vite
  3. Try to download /Hello%20World.css or /Hello+World.css
  4. You get a 404 response

Source of the issue is related to sirv, see
lukeed/sirv#82

System Info

  • vite version: 2.0.0-beta.12
  • Operating System: Win 10
  • Node version: 15.5.1
  • Package manager (npm/yarn/pnpm) and version: npm 7.3.0
underfin added a commit to rolldown/vite that referenced this issue Jan 8, 2021
@underfin
fix(dev): decode url before sirv resolve
caa9388 
fix vitejs#1426
@underfin underfin mentioned this issue Jan 8, 2021
Merged
yyx990803 pushed a commit that referenced this issue Jan 8, 2021
@underfin
fix(dev): decode url before sirv resolve (#1432)
7cc3cf1 
fix #1426
@jods4
Copy link
Contributor Author

jods4 commented Jan 8, 2021

That was fast, thanks. 🙇
Looking forward to the next beta.

@andylizi andylizi mentioned this issue Jun 5, 2021
Merged
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pending triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dev): decode url before sirv resolve rolldown/vite
1 participant
@jods4