ssrLoadModule promises resolve even if evaluation fails

[Rich-Harris]

Describe the bug

Suppose you have a module, bad-module.js, which throws an error on evaluation. If you import('bad-module.js') the promise will reject, but if you load it with ssrLoadModule('bad-module.js'), the promise resolves to a module record with no exports.

This means it's difficult to know if an error occurred (especially if you don't know what shape the module should have) and impossible (AFAICT) to get hold of the error itself. For consistency, I'd expect it the error here to be rethrown:

vite/packages/vite/src/node/ssr/ssrModuleLoader.ts

Lines 111 to 120 in d0eac2f

	} catch (e) {
	e.stack = ssrRewriteStacktrace(e.stack, moduleGraph)
	server.config.logger.error(
	`Error when evaluating SSR module ${url}:\n${e.stack}`,
	{
	timestamp: true,
	clear: true
	}
	)
	}

(As an aside, clear: true means that the clearScreen option isn't respected — not sure if this function has access to that config?)

Reproduction

https://github.com/Rich-Harris/vite-ssr-load-errors

System Info

• vite version: 2.0.1
• Operating System: Mac OS
• Node version: 12.18.3
• Package manager (npm/yarn/pnpm) and version: npm 6.14.6