Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): fix sass importer error #3368

Merged
merged 2 commits into from
May 12, 2021
Merged

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented May 11, 2021

close #3180

Description

This PR Solves #3180, adding a simple mechanism to enable the usage of importer through preprocessorOptions in css configuration options.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels May 12, 2021
underfin
underfin previously approved these changes May 12, 2021
packages/playground/css/sass.scss Outdated Show resolved Hide resolved
Co-authored-by: patak <matias.capeletto@gmail.com>
@patak-dev patak-dev requested a review from underfin May 12, 2021 17:14
@antfu antfu merged commit 3f04abf into vitejs:main May 12, 2021
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
Co-authored-by: patak <matias.capeletto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Establish a mechanism that can intervene in the sass / scss importer
5 participants