Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite's HMR fails when a file has more than one glob import. #3496

Closed
brillout opened this issue May 20, 2021 · 1 comment · Fixed by #3497
Closed

Vite's HMR fails when a file has more than one glob import. #3496

brillout opened this issue May 20, 2021 · 1 comment · Fixed by #3497
Labels
pending triage

Comments

@brillout
Copy link
Contributor

brillout commented May 20, 2021 •
edited
Loading

The PR #3497 fixes this.
brillout added a commit to brillout/vite that referenced this issue May 20, 2021
@brillout
fix: properly handle HMR for files with more than one glob import (fix …
77de0e4 
…vitejs#3496)
@brillout
Copy link
Contributor Author

The root problem is this:

vite/packages/vite/src/node/plugins/importAnalysis.ts

Lines 303 to 308 in 06b9935

server._globImporters[importerModule.file!] = {
module: importerModule,
base,
pattern
}
}
.

As you can see _globImporters can hold only one glob per file. Any additional glob will overwrite the previous one.

The linked PR merely changes _globImporters to hold an array of globs per file.

This leads to a bug in vite-plugin-ssr causing vikejs/vike#66.

@brillout brillout mentioned this issue May 20, 2021
Merged
brillout added a commit to brillout/vite that referenced this issue May 21, 2021
@brillout
fix: properly handle HMR for files with more than one glob import (fix …
f844689 
…vitejs#3496)
brillout added a commit to brillout/vite that referenced this issue May 21, 2021
@brillout
fix: properly handle HMR for files with more than one glob import (fix …
85c047b 
…vitejs#3496)
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pending triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle HMR for files with more than one glob import brillout/vite
2 participants
@brillout @Shinigami92