fix: ensure new CSS modules cache at build start #3516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is related to #3512. I don't have a test for it, but looks like not resetting the cache can lead to stale CSS modules caches so it is better to have a clean cache at build start following the same pattern as with the assets plugin.
For a theoric reproduction of the stale cache, when rebuilding in watch mode, if there was an id that generated
modules
asundefined
after being properly defined in the previous build, then it will not reset the cached id herevite/packages/vite/src/node/plugins/css.ts
Line 174 in 5979d0e
So, the old cached value will remain in the map and could be used in the
vite:css-post
plugin herevite/packages/vite/src/node/plugins/css.ts
Line 240 in 5979d0e
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).