Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure new CSS modules cache at build start #3516

Merged
merged 3 commits into from
May 25, 2021
Merged

fix: ensure new CSS modules cache at build start #3516

merged 3 commits into from
May 25, 2021

Conversation

patak-dev
Copy link
Member

Description

This is related to #3512. I don't have a test for it, but looks like not resetting the cache can lead to stale CSS modules caches so it is better to have a clean cache at build start following the same pattern as with the assets plugin.

For a theoric reproduction of the stale cache, when rebuilding in watch mode, if there was an id that generated modules as undefined after being properly defined in the previous build, then it will not reset the cached id here


So, the old cached value will remain in the map and could be used in the vite:css-post plugin here
modules && dataToEsm(modules, { namedExports: true, preferConst: true })


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Shinigami92
Shinigami92 previously approved these changes May 24, 2021
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 24, 2021
@patak-dev patak-dev requested a review from antfu May 24, 2021 10:28
@underfin
Copy link
Member

Maybe here also need reset cache for css.

const outputToExtractedCSSMap = new Map<NormalizedOutputOptions, string>()

@patak-dev
Copy link
Member Author

Updated the PR to also generate new caches at build start for the vite:css-post plugin as proposed by @underfin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants