Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data-uri, build-html plugins caches at buildStart #3535

Closed
wants to merge 2 commits into from
Closed

fix: data-uri, build-html plugins caches at buildStart #3535

wants to merge 2 commits into from

Conversation

patak-dev
Copy link
Member

Description

See also #3516, #3512 and #3530

This PR generate new caches at buildStart for vite:data-uri and vite:build-html. These are the last two plugins that had caches that weren't regenerated for each build.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 25, 2021
@patak-dev patak-dev marked this pull request as draft May 25, 2021 07:24
@patak-dev
Copy link
Member Author

Closing this one, data-uri plugin was closed in #3537, build-html caches still needs to be worked out but seems this is not the correct approach as tests are failing.

@patak-dev patak-dev closed this May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants