Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade esbuild for esm compatibility #3718

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix: upgrade esbuild for esm compatibility #3718

merged 1 commit into from
Jun 8, 2021

Conversation

lbwa
Copy link
Contributor

@lbwa lbwa commented Jun 8, 2021

fix #3399 fix #3413

Description

esbuild v0.12.7 has added esm marker for specific esm scenario.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the dependencies Pull requests that update a dependency file label Jun 8, 2021
@Niputi
Copy link
Contributor

Niputi commented Jun 8, 2021

should also fix #3617

@antfu antfu merged commit dbb5eab into vitejs:main Jun 8, 2021
@lbwa lbwa deleted the esbuild-esm branch June 9, 2021 01:44
@patak-dev patak-dev mentioned this pull request Jun 10, 2021
Closed
6 tasks
@185172970 185172970 mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@nihalgonsalves nihalgonsalves Awaiting requested review from nihalgonsalves

@patak-dev patak-dev Awaiting requested review from patak-dev

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
4 participants
@lbwa @Niputi @Shinigami92 @antfu