Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4.0-beta.1] Break nested module resolve #4014

Closed
6 tasks done
odex21 opened this issue Jun 29, 2021 · 4 comments
Closed
6 tasks done

[2.4.0-beta.1] Break nested module resolve #4014

odex21 opened this issue Jun 29, 2021 · 4 comments

Comments

@odex21
Copy link

odex21 commented Jun 29, 2021

Describe the bug

@vueuse/router import a cjs version vue-router
image

Reproduction

https://github.com/odex21/vite-2.4.0-beta.1-repo

yarn
cd packages/main
yarn dev

check the link http://localhost:3000/#/?id=123

System Info

System:
    OS: Windows 10 10.0.19042
    CPU: (16) x64 AMD Ryzen 7 5800H with Radeon Graphics
    Memory: 2.16 GB / 13.87 GB
  Binaries:
    Node: 14.16.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - C:\Program Files\nodejs\yarn.CMD
    npm: 6.14.12 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1023.0), Chromium (91.0.864.59)
    Internet Explorer: 11.0.19041.1

Used Package Manager

yarn

Logs

No response

Validations

@patak-dev
Copy link
Member

Probably same as #4005, see PR being reviewed #3753

@patak-dev
Copy link
Member

@odex21 would you check if your issue is resolved in vite@2.4.0-beta.2 (just released)?

@odex21
Copy link
Author

odex21 commented Jun 29, 2021

@odex21 would you check if your issue is resolved in vite@2.4.0-beta.2 (just released)?

Yes, it works fine now in 2.4.0-beta.2

@github-actions
Copy link

This issue has been locked since it has been closed for more than 14 days.

If you have found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Vite version. If you have any other comments you should join the chat at Vite Land or create a new discussion.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants